Enable Strict Mypy Type Checking #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary type: ignore comments, improved type annotations, and updated function signatures for better type safety across chat models, embeddings, and tests. Also enhanced mypy configuration for stricter type checking and plugin support.
oracle-contributor-agreement
bot
added
the
OCA Verified
…n-oracle/libs/oci/tests/unit_tests/chat_models/test_oci_data_science.py
Removes 'test' and 'test_integration' groups from the Poetry install step in the lint workflow, ensuring only linting and typing dependencies are installed during lint jobs.
This reverts commit 3170d1d.
Introduced steps to free disk space in both lint and test GitHub Actions workflows by removing unused Android and CodeQL directories and pruning Docker images. This helps prevent CI failures due to insufficient disk space.
YouNeedCryDear
approved these changes
Nov 19, 2025
Member
|
@fileames Could you take a look at the oracledb level to make sure there is no breaking changes? |
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables stricter mypy type checking for both langchain-oci and langchain-oracledb libraries, following the mypy configuration from langchain-google/vertexai.
Changes
Mypy Configuration:
Type Safety Fixes:
Testing
✅ All unit tests pass
✅ make lint passes with zero mypy errors